Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOAIENG-6880] Disable homePage feature flag for RHOAI deployments #2784

Merged
merged 1 commit into from
May 7, 2024
Merged

[RHOAIENG-6880] Disable homePage feature flag for RHOAI deployments #2784

merged 1 commit into from
May 7, 2024

Conversation

jeff-phillips-18
Copy link
Contributor

Closes: RHOAIENG-6880

Description

The disableHome flag was inadvertently set to false for the RHOAI odhDashbardConfig spec.

Test Impact

On the nightly build of a RHOAI deployment, verify the home page is not show and the initial page is the enabled application page.

Request review criteria:

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).

andrewballantyne
andrewballantyne approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should resolve that issue -- minor annoyance as we work through enabling the feature.

@openshift-ci openshift-ci bot added the lgtm label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4e0d064 into opendatahub-io:main May 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@DaoDaoNoCode DaoDaoNoCode Awaiting requested review from DaoDaoNoCode

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

Assignees

@andrewballantyne andrewballantyne

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-phillips-18 @andrewballantyne